Skip to content

Conversation

@edrevo
Copy link
Contributor

@edrevo edrevo commented Feb 25, 2021

Unit tests now cover the bug to avoid regressions.

@edrevo
Copy link
Contributor Author

edrevo commented Feb 25, 2021

cc @andygrove

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. LGTM!

@github-actions
Copy link

@edrevo
Copy link
Contributor Author

edrevo commented Feb 25, 2021

I really need an fmt hook in my git... Fmt fixed!

@edrevo
Copy link
Contributor Author

edrevo commented Feb 26, 2021

@andygrove, I think the CI failure is unrelated to this change. Can you confirm?

@alamb
Copy link
Contributor

alamb commented Feb 26, 2021

@edrevo the integration test failure looks like https://issues.apache.org/jira/browse/ARROW-11717 to me (not related to your PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants